Committing this patch, seeing as there have been no objections. Francis
On Tue, 2006-07-18 at 15:17 -0400, Francis Kung wrote: > Hi, > > This patch implements the KeySelectionManager for JComboBox, as well as > fixing up the navigation keys and highlighting the combobox when it's in > focus. > > Corresponding mauve test for the key actions has been committed. I > would appreciate any comments, or approval to commit. > > Cheers, > Francis > > > 2006-07-18 Francis Kung <[EMAIL PROTECTED]> > > * javax/swing/JComboBox.java > (DefaultKeySelectionManager): Implemented. > (createDefaultKeySelectionManager): Implemented. > (getKeySelectionManager): Implemented. > (processKeyEvent): Removed duplicate code. > * javax/swing/JPopupMenu.java > (selectionModel): Changed visibility. > * javax/swing/plaf/basic/BasicComboBoxUI.java > (KeyHandler.keyPressed): Added navigation keys. > (configureEditor): Add key listener. > (installListeners): Install focus listener to combo box. > (isNavigationKey): Added enter, escape, and tab. > (selectPreviousPossibleValue): Added out of bounds check. > (unconfigureEditor): Remove key listener. > * javax/swing/plaf/metal/MetalComboBoxButton.java > (paintComponent): Highlight combo box when in focus. >
