I unmarked 2 stubs in BasicTableHeaderUI. Accordings to some simple tests that I did, the RI never installs any keyboard actions on the JTableHeader component, but the UI provides these methods anyway, presumably as hooks for subclasses.

2006-08-13  Roman Kennke  <[EMAIL PROTECTED]>

        * javax/swing/plaf/basic/BasicTableHeaderUI.java
        (installKeyboardAction): Unmarked as stub. Added comment
        explaining that the RI seems to do nothing here.
        (uninstallKeyboardAction): Unmarked as stub. Added comment
        explaining that the RI seems to do nothing here.

/Roman
Index: javax/swing/plaf/basic/BasicTableHeaderUI.java
===================================================================
RCS file: /cvsroot/classpath/classpath/javax/swing/plaf/basic/BasicTableHeaderUI.java,v
retrieving revision 1.23
diff -u -1 -2 -r1.23 BasicTableHeaderUI.java
--- javax/swing/plaf/basic/BasicTableHeaderUI.java	13 Jun 2006 09:28:57 -0000	1.23
+++ javax/swing/plaf/basic/BasicTableHeaderUI.java	13 Aug 2006 22:19:11 -0000
@@ -29,26 +29,24 @@
 modules, and to copy and distribute the resulting executable under
 terms of your choice, provided that you also meet, for each linked
 independent module, the terms and conditions of the license of that
 module.  An independent module is a module which is not derived from
 or based on this library.  If you modify this library, you may extend
 this exception to your version of the library, but you are not
 obligated to do so.  If you do not wish to do so, delete this
 exception statement from your version. */
 
 
 package javax.swing.plaf.basic;
 
-import gnu.classpath.NotImplementedException;
-
 import java.awt.Component;
 import java.awt.Cursor;
 import java.awt.Dimension;
 import java.awt.Graphics;
 import java.awt.Rectangle;
 import java.awt.event.ActionEvent;
 import java.awt.event.ActionListener;
 import java.awt.event.MouseEvent;
 
 import javax.swing.CellRendererPane;
 import javax.swing.JComponent;
 import javax.swing.LookAndFeel;
@@ -406,27 +404,26 @@
     mouseInputListener = createMouseInputListener();
   }
 
   protected void installDefaults()
   {
     LookAndFeel.installColorsAndFont(header, "TableHeader.background",
                                      "TableHeader.foreground",
                                      "TableHeader.font");
     cellBorder = UIManager.getBorder("TableHeader.cellBorder");
   }
 
   protected void installKeyboardActions()
-    throws NotImplementedException
   {
-    // TODO: Implement this properly.
+    // AFAICS, the RI does nothing here.
   }
 
   /**
    * Add the mouse listener and the mouse motion listener to the table
    * header. The listeners support table column resizing and rearrangement
    * by mouse.
    */
   protected void installListeners()
   {
     header.addMouseListener(mouseInputListener);
     header.addMouseMotionListener(mouseInputListener);
   }
@@ -439,27 +436,26 @@
     installKeyboardActions();
     installListeners();
   }
 
   protected void uninstallDefaults()
   {
     header.setBackground(null);
     header.setForeground(null);
     header.setFont(null);
   }
 
   protected void uninstallKeyboardActions()
-    throws NotImplementedException
   {
-    // TODO: Implement this properly.
+    // AFAICS, the RI does nothing here.
   }
   
   /**
    * Remove the previously installed listeners.
    */
   protected void uninstallListeners()
   {
     header.removeMouseListener(mouseInputListener);
     header.removeMouseMotionListener(mouseInputListener);
   }
 
   public void uninstallUI(JComponent c)

Reply via email to