Roman Kennke wrote:
> Friedjof hacked up the Object de-/serialization code for improved
> performance. It is now an order of magnitude faster.
Thanks. Most of it looks good. A few comments:
This looks funny:
+ {System.err.println("1");
I think this is bad style:
+ catch (IllegalArgumentException _)
+ {
+ InvalidClassException e = new InvalidClassException
+ ("writing fields of class " + osc.forClass().getName());
+ e.initCause(_);
I would only use _ if the exception object is not used.
This test is wrong:
+ || (l.getClass().getClassLoader() == null /* application loader
*/);
If an application instantiates URLClassLoader, it should still be
garbage collectable.
I think that he should consider using a cache that uses weak references
instead of this test.
Regards,
Jeroen
