Tom Tromey wrote:
"Andreas" == Andreas Tobler <[EMAIL PROTECTED]> writes:
Andreas> the attached patch fixes the current cvs on darwin-ppc. Not tested on
Andreas> functionality yet. But it builds :)
This mostly looks ok to me. I just had one question.
Andreas> +#if defined (HAVE_MSG_NOSIGNAL)
Andreas> +#define SOCKET_NOSIGNAL MSG_NOSIGNAL
Andreas> +#elif defined (HAVE_SO_NOSIGPIPE)
Andreas> +#define SOCKET_NOSIGNAL SO_NOSIGPIPE
Andreas> +#else
Andreas> +#define SOCKET_NOSIGNAL 0
Andreas> +#endif
Why default to 0 here? If we don't know what to do perhaps it would
be better to #error.
It's just a fallback I chose. I need to test solaris and hpux-pa. But
atm I do not have the time to. I'm fine with #error for the time being.
I'll update asap I had time to test and fix on those archs (I know
they'll have troubles too here). Possibly the #error will stay as default.
Thanks Tom for the review.
Andreas
