hello Sven, On Sunday 03 September 2006 19:46, Sven de Marothy wrote: > On Sun, 2006-09-03 at 10:02 +0200, Jeroen Frijters wrote: > > Raif S. Naffah wrote: > > > the attached patch adds support for GNU MP in BigInteger > > > if/when configured. > > > > How/why is the native version better? Is it really worthwhile to > > complicate the code this way? Where are the benchmarks that prove the > > native code is faster? > > Valid questions, indeed...
indeed. see my previous reply to Jeroen about the performance. > ... > What I'd like to propose here is that in any case, the choice of > implementation should be strictly a build-time option, and the > two implementations kept entirely seperate. i thought having the java code in one place is clearer, and helps showing the common elements... but this is my opinion. > I'm not very happy about the alternatives: Having two implementations in > one class (as in the proposed patch), or moving the actual impl into yet > another VM* class. (Indeed I've been increasingly critical recently over > that part. I've still not worked out an exact solution, but suffice to > say that I'll be proposing some changes in that area soon). from the sound of it, it looks like now is the time! > Anyway enough disgression, I hope I didn't sound harsh, Raif! :)... not at all. cheers; rsn
pgp1XgzgloFe0.pgp
Description: PGP signature
