On Wed, 2006-09-13 at 14:37 -0400, Thomas Fitzsimmons wrote: > Tania Bento wrote: > > Hey Tom, > > > >> Looks fine, except: > >> > >>> + if (row == 0 && column == 0) > >>> + cellRect.width = 75; > >> How is this value derived? > >> > >> Tom > > > > I wrote a mauve test for this. I just committed it. > > OK, I was just wondering if this should be a configurable property, perhaps > based on the cell font size or the current look-and-feel. > > Tom
Take a look at the TableColumn class - the constructors that don't specify a width are specified as using 75 for the default width. So this value should most likely come from the TableColumn, not a magic constant. I haven't looked at the whole of this patch, but the new check in the getCellRect() method seems unnecessary, since the bounds have already been checked earlier in the method. I think we should have Mauve tests to cover each of these changes before they are committed. Regards, Dave
