Hi Tania, > This patch fixes a few bugs exposed by Bugzilla Bug #203674. I think > the ChangeLog explains the changes well. > > Could someone kindly approve/comment on this patch.
The JTable and BasicTableUI fixes look good. Please don't try-catch NullPointerExceptions. It is much more efficient to check for null with xyz == null before an exception can be thrown. Besides that, it makes a patch much more readable if re-indentation is avoided. This should be done in a separate patch if possible. ( I must blame myself here, as I sometimes post such patches myself ). Cheers, Roman > > Thanks, > Tania > > 2006-08-28 Tania Bento <[EMAIL PROTECTED]> > > * javax/swing/plaf/basic/BasicTableUI.java > (getPreferredSize): The number of iterations for the for-loop should be > the number of columns in the table's column model, not the number of > columns of the table. > * gnu/java/awt/peer/gtk/ComponentGraphics.java > (drawImage): Added a try/catch block to prevent a NullPointerException > from being thrown. > * javax/swing/JTable.java > (JTable(TableModel, TableColumnModel, ListSelectionModel): Removed 4 > lines that are not needed. > (initializeLocalVars): dragEnabled should be set to false, not true. > (getCellRenderer): Added a check to prevent an > ArrayIndexOutOfBoundsException. > (doLayout): The number of iterations for the for-loops should be the > number of columns in the table's column model, not the number of columns > of the table.
