Hi,
Roman Kennke wrote:
[...]
+JNIEXPORT void JNICALL
+Java_gnu_java_awt_peer_gtk_GtkFramePeer_unmaximize
+(JNIEnv *env, jobject obj)
+{
+ void *ptr;
+ gdk_threads_enter ();
+ ptr = NSA_GET_PTR (env, obj);
+ gtk_window_unmaximize (GTK_WINDOW (ptr));
+ gdk_threads_leave ();
+}
For consistency, can you leave a blank line before and after the
gdk_threads_enter call and before the gdk_threads_leave call? This
makes it easier to visually verify that the locking functions are called
at the start and and end of each function in the peers.
[...]
+ // Post old styleWindowEvent with WINDOW_ICONIFIED or
Typo in comment.
Other than these little things, this patch looks good.
Tom
