hello Casey, On Tuesday 21 November 2006 08:35, Casey Marshall wrote: > ... > This patch fixes an issue with JarEntry objects that are created > before the entry is verified: we used to bind the certificates to a > JarEntry at creation time, so if the entry has not been verified yet, > the certificates field will be null. This is contrary to the JDK > behavior. > > This changes JarEntry to hold a pointer of its containing JarFile, > and getCertificates now just accesses the "entryCerts" field of > JarFile directly. Thus, once an entry is verified, its certificates > may be looked up with a previously-initialized entry...
i've added a new method to the Mauve test in gnu/testlet/java/util/jar/JarFile/TestOfManifest.java to highlight this issue. with both RI 1.4 (1.4.2_13) and 1.5 (1.5.0_09) the behavior is the same: the counts of certificates is 0, 1, and 1 respectively. before your patch our implementation outputs 0, 0, and 1, and after the patch: 1, 1, and 1 which is different in both cases. cheers; rsn
pgpBTLpE0d9sL.pgp
Description: PGP signature