>>>>> "Mario" == Mario Torre <[EMAIL PROTECTED]> writes:
Mario> I've found a number of Empty control-flow statement that ecj
Mario> (or better, Eclipse) complains and don't compile.
What version of Eclipse is this? Did you need to change the Eclipse
build setup to see this? I'm asking because I think that if this is
an Eclipse build setting, we should set it to 'error' so that we won't
break this in the future. (And we should set it in the Makefiles too.)
I can't think of a reason we'd want code like this...
Mario> if (text != null); <--------
Mario> sb.append(text);
Mario> Look at the semicolon.
Yeah, delete it.
Mario> if (get(o) == null); <--------
Mario> super.writeObject(o);
Likewise.
I think these are clear from the indentation.
Mario> Another tricky method is gnu.java.nio.charset.ByteCharset.decodeLoop:
Your fix looks fine here as well. Thanks.
Tom
