Re: [cp-patches] FYI: Permission minor fix

[David Daney]

Roman Kennke wrote:
Hi,
  
This fixes a minor bug in Permission's toString method.  I also changed
it to use a StringBuffer instead.  
    

Why not use StringBuilder? Seems slightly more efficient.

/Roman

  
Why not leave it much as it was using the string concatenation operator 
'+'?  The compiler converts this to String[Buffer|Builder] when it 
generates the byte code. IMO this patch makes the code much more 
difficult to understand with *no* improvement in efficiency.

David Daney