Kyle Galloway wrote:
ChangeLog
2007-04-11 Kyle Galloway <[EMAIL PROTECTED]>
* gnu/classpath/jdwp/processor/ReferenceTypeCommandSet.java
(executeSourceFile): Throw an exception if no source file was found.
Questions/comments/concerns?
Hmm. I'm not convinced this is the right way to do this... My initial
reaction is to have VMVirtualMachine.getSourceFile throw the exception
instead of the return value being reinterpreted. After all, it should
know the *exact* reason it cannot return the requested information. All
VMVirtualMachine methods are declared throwing JdwpException for this
reason.
But perhaps you considered this already and discounted it for some reason?
Keith
PS. Along similar lines, I think that there are a lot of hidden problems
with gcj's implementation of VMVirtualMachine. All the unimplemented
stub functions return NULL or 0 (or some such thing) instead of throwing
NotImplementedException. I think this just confuses things.
