Re: [cp-patches] RFC: old DeleteLocalRef patch

[Mark Wielaard]

Hi Christian,

On Wed, 2007-04-11 at 22:26 +0200, Christian Thalinger wrote:
> I just found this one in my local working copy.  Should I commit it?

It is correct as far as I can see. So please do commit.
Do you actually have so little LocalRefs that you notice this in cacao?

Could you please write a changelog entry and fix this little nitpick?

> -         if (text == NULL)
> +         if (text == NULL) {
> +           (*env)->DeleteLocalRef(env, uri);
>             break;
> +          }

brackets go:
if ()
  {
    bla ();
    break;
  }

Thanks,

Mark

signature.asc
Description: This is a digitally signed message part