Re: [cp-patches] Little XML patch

[Chris Burdess]

Christian Thalinger wrote:

On Mon, 2007-04-09 at 21:11 +0200, Christian Thalinger wrote:

On Mon, 2007-04-09 at 19:17 +0200, Christian Thalinger wrote:

Ok, here we go:


ids.systemId=jbb-document.dtd
url=jbb-document.dtd

input.systemId=file:/home/twisti/cacao/spec/jbb2005/xml/template- document.xml

This is the output before Chris' patch:


url=file:/home/twisti/cacao/spec/jbb2005/xml/jbb-document.dtd

input.systemId=file:/home/twisti/cacao/spec/jbb2005/xml/template- document.xml ids.systemId=file:/home/twisti/cacao/spec/jbb2005/xml/jbb- document.dtd

Ok, finally I was able to build a testcase.

  file:/home/dog/test/twisti-xml/xml/test.xml

According to RFC 1738:

   A file URL takes the form

      file://<host>/<path>

   where <host> is the fully qualified domain name of the system on
   which the <path> is accessible, and <path> is a hierarchical
   directory path of the form <directory>/<directory>/.../<name>.

...

   As a special case, <host> can be the string "localhost" or the empty
   string; this is interpreted as `the machine from which the URL is
   being interpreted'.

Therefore File.toURL should be returning a URL of the form

  file:///home/dog/test/twisti-xml/xml/test.xml

Let the flamewar commence...

I've found the problem. java.io.File.toURL() is returning an invalid URL in DomLSParser.getInputSource. I'm sure we've been over this a hundred times or more but maybe it's time to revisit this yet again. Here is an example of a "URL" returned in my local testcase:

PGP.sig
Description: This is a digitally signed message part