On May 30, 2007, at 4:21 AM, Steve Blackburn wrote:
Is there any particular reason for having native implementations of open() in both gnu_java_nio_VMChannel.c and gnu_java_nio_FileChannelImpl.c? Aside from the bug in VMChannel, this duplication of open seemed to be the cause of the problem I saw.
gnu_java_nio_FileChannelImpl.c was removed from CVS, six months ago.
Refactoring of FileChannelImpl.java lead to an (unintended?) switch between open() implementations and exposed the bug. I couldn't work out why there were two implementations in the first place.
The point of the refactoring was to move all of the native methods from FileChannelImpl into the the VM/platform layer, VMChannel. It was completely deliberate to switch to VMChannel -- that was the point.
As for the bug, oops (I think it may have been my fault).
