Hi Roman, On Thu, 2007-06-21 at 16:55 +0200, Roman Kennke wrote: > The reason why I post this as RFC is that I added the > sun.awt.CausedFocusEvent class. This class is needed in the > java.awt.peer.ComponentPeer interface. I rewrote it completely but I > have to admit that I have looked at OpenJDK's version before.. > > Ok to go in?
Thanks. I think this file is fine since it is so super small and just lists a bunch of constants (not copyrightable), in the only obvious way to add a constructor and is clearly meant to provide compatibility. Ideally this class would of course be part of the public awt.peer interface, but seeing your struggle to get changes into openjdk already that might be a long "fight". So lets add this for compatibility sake. I do have to warn that in general it is a problem to add files derived from openjdk into classpath at the moment. There is a small, but significant difference between classpath and openjdk and that is that classpath uses gplv2 (or later) plus exception and openjdk uses gplv2 (only). And the plan always was to upgrade to gplv3 because it provides some much needed improvements. I'll have a meeting with Eben Moglen this weekend where I will discuss this and other pending legal issues. But it would be nice to get some assurance from Sun that they also want to upgrade. Cheers, Mark
