>>>>> "Ian" == Ian Rogers <[EMAIL PROTECTED]> writes:

Ian> the attached patch stops the lazy initialization of a Calendar object
Ian> in ZipEntry and instead uses a static final one.

I thought this could lead to odd results sometimes, when the
calendrical data is in a zip.  But it is hard to remember.  Maybe a
bit of archaeology is in order -- looking through the cvs logs or the
list archives to see why the code is the way it is.  (That info should
be in comments, of course...)

Ian> It also modifies the clone method to instead of using
Ian> Object.clone to use the ZipEntry's own copy constructor.

This isn't a safe transform if the class is not final.  Cloning a
subclass will yield the wrong type.

Tom

Reply via email to