Andrew John Hughes wrote:
This fixes a problem in the build introduced by Dalibor's
latest patch. The check_jni_methods script is generated
using @top_builddir@, which is a relative path that will be
'..' from scripts (where check_jni_methods lives). However,
Dalibor's patch also calls the script from native/jni which
has a @top_builddir@ of ../../. Thus, when it comes time
to run the script, it can't find the include files as the script
uses the wrong relative path:
make[3]: Entering directory `/home/andrew/builder/classpath/native/jni'
/bin/sh ../../scripts/check_jni_methods.sh
grep: ../include/*.h: No such file or directory
Found a problem with the JNI methods declared and implemented.
This patch fixes it by using abs_top_builddir instead. There is still
a remaining minor issue in that the header files aren't generated in
the build directory of a parallel build if they exist in the source
directory.
Thanks, Andrew, for spotting and fixing it so quickly. And sorry for
introducing it ...
cheers,
dalibor topic
