On 17/02/2008, Andrew John Hughes <[EMAIL PROTECTED]> wrote: > I noticed when trying to fix PR34840 that we have > a lot of duplicate code between StringBuffer and > StringBuilder. This patch abstracts most of it > into a common superclass. Testing PR34840 showed > that OpenJDK already does this. > > PR21869 is also then trivial, as we just need an > additional Classpath string buffer that doesn't > create a copy when toString() is called (as in > GCJ). > > Comments? I'll commit Monday if there are no > objections. > > Thanks, > > -- > Andrew :) > > Support Free Java! > Contribute to GNU Classpath and the OpenJDK > http://www.gnu.org/software/classpath > http://openjdk.java.net > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.6 (GNU/Linux) > > iD8DBQFHt8KrAQUyfTZIWfoRAsD7AJ90RBSagUpL7Z4Ih68r+ekkAfmjkACfW6wF > 6sCuK7cAJmyf+WonTYS5Rdk= > =TWTG > -----END PGP SIGNATURE----- > > >
Committed. 2008-02-26 Andrew John Hughes <[EMAIL PROTECTED]> PR classpath/21869: * java/lang/AbstractStringBuffer.java: New class. * java/lang/StringBuffer.java, * java/lang/StringBuilder.java: Changed to use AbstractStringBuffer. -- Andrew :-) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net