Hi Tom, On Thu, 2008-04-17 at 16:45 -0600, Tom Tromey wrote: > I'm checking this in. > > This is a patch from a gcc contributor to speed up gen-classlist.sh. > See the attached email for the details. > (Well, the link in the attached email...)
Something is broken in this patch, at least for in srcdir builds. I end up with an empty cat | sed which then just sits there. I believe it comes from: > > +vm_omitlist= > > for dir in $vm_dirlist; do > > if test -f $dir/$1.omit; then > > - for filexp in `cat $dir/$1.omit`; do > > - grep -v $filexp < vm.add > vm.add.1 > > - mv vm.add.1 vm.add > > - done > > + vm_omitlist="$vm_omitlist $dir/$1.omit" > > fi > > done > > -cat vm.add >> classes.1 > > +cat $vm_omitlist | sed "$sed_omit_hash" > tmp.awk > > +cat $vm_omitlist | sed "$sed_omit_main_loop" >> tmp.awk At this point $vm_dirlist is ../vm/reference and $1 is standard, but there is no ../vm/reference/standard.omit file, so $vm_omitlist will stay empty leading to the empty cat | sed. I don't really know what the intention is here. I assume that the whole sedding should be skipped if there is no such omit file. Could you take a look? Thanks, Mark
