2008/5/15 Robert Schuster <[EMAIL PROTECTED]>:
> Hi,
>  I committed this today.
>
>  2008-05-15  Robert Schuster  <[EMAIL PROTECTED]>
>
>
>   * java/net/NetworkInterface.java:
>   (isUp): New method.
>   (isPointToPoint): Dito.
>   (isLoopback): Dito.
>   (supportsMulticast): Dito.
>   * vm/reference/java/net/VMNetworkInterface.java:
>   (isUp): New method.
>   (isPointToPoint): Dito.
>   (isLoopback): Dito.
>   (supportsMulticast): Dito.
>   * native/jni/java-net/java_net_VMNetworkInterface.c:
>   (isUp): New method.
>   (isPointToPoint): Dito.
>   (isLoopback): Dito.
>   (supportsMulticast): Dito.
>
>  Regards
>  Robert
>
>  Robert Schuster schrieb:
>
>
> > Hi.
>  >
>  > Robert Schuster schrieb:
>  >> Hi,
>  >> I fixed the copy and paste error and another flaw. Casting to jboolean
>  >> did not alway returned the correct result. I made the if-flag-set then
>  >> JNI_TRUE otherwise JNI_FALSE explicit. Now it works correctly.
>  > If no one objects I would like to commit this patch.
>  >
>  > Regards
>  > Robert
>  >
>
>
>


FWIW, this made us regress on building on Solaris 9:


if /bin/bash ../../../libtool --tag=CC --mode=compile gcc
-DHAVE_CONFIG_H -I.
-I/share/nlp/projects/cashew/sources/classpath/native/jni/java-net
-I../../../include
-I/share/nlp/projects/cashew/sources/classpath/include
-I/share/nlp/projects/cashew/sources/classpath/native/jni/classpath
-I/share/nlp/projects/cashew/sources/classpath/native/jni/native-lib
-W -Wall -Wmissing-declarations -Wwrite-strings -Wmissing-prototypes
-Wno-long-long -Wstrict-prototypes -pedantic -Werror -g -O2 -MT
java_net_VMNetworkInterface.lo -MD -MP -MF
".deps/java_net_VMNetworkInterface.Tpo" -c -o
java_net_VMNetworkInterface.lo
/share/nlp/projects/cashew/sources/classpath/native/jni/java-net/java_net_VMNetworkInterface.c;
\
then mv -f ".deps/java_net_VMNetworkInterface.Tpo"
".deps/java_net_VMNetworkInterface.Plo"; else rm -f
".deps/java_net_VMNetworkInterface.Tpo"; exit 1; fi
 gcc -DHAVE_CONFIG_H -I.
-I/share/nlp/projects/cashew/sources/classpath/native/jni/java-net
-I../../../include
-I/share/nlp/projects/cashew/sources/classpath/include
-I/share/nlp/projects/cashew/sources/classpath/native/jni/classpath
-I/share/nlp/projects/cashew/sources/classpath/native/jni/native-lib
-W -Wall -Wmissing-declarations -Wwrite-strings -Wmissing-prototypes
-Wno-long-long -Wstrict-prototypes -pedantic -Werror -g -O2 -MT
java_net_VMNetworkInterface.lo -MD -MP -MF
.deps/java_net_VMNetworkInterface.Tpo -c
/share/nlp/projects/cashew/sources/classpath/native/jni/java-net/java_net_VMNetworkInterface.c
 -fPIC -DPIC -o .libs/java_net_VMNetworkInterface.o
cc1: warnings being treated as errors
/share/nlp/projects/cashew/sources/classpath/native/jni/java-net/java_net_VMNetworkInterface.c:
In function 'iff_flags':
/share/nlp/projects/cashew/sources/classpath/native/jni/java-net/java_net_VMNetworkInterface.c:277:
warning: implicit declaration of function 'ioctl'
/share/nlp/projects/cashew/sources/classpath/native/jni/java-net/java_net_VMNetworkInterface.c:277:
error: 'SIOCGIFFLAGS' undeclared (first use in this function)
/share/nlp/projects/cashew/sources/classpath/native/jni/java-net/java_net_VMNetworkInterface.c:277:
error: (Each undeclared identifier is reported only once
/share/nlp/projects/cashew/sources/classpath/native/jni/java-net/java_net_VMNetworkInterface.c:277:
error: for each function it appears in.)
make[3]: *** [java_net_VMNetworkInterface.lo] Error 1
make[3]: Leaving directory
`/share/nlp/projects/cashew/build/sparc-sun-solaris2.9/classpath/native/jni/java-net'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory
`/share/nlp/projects/cashew/build/sparc-sun-solaris2.9/classpath/native/jni'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
`/share/nlp/projects/cashew/build/sparc-sun-solaris2.9/classpath/native'
make: *** [all-recursive] Error 1

-- 
Andrew :-)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8

Reply via email to