On 22/05/2008, Joshua Sumali <[EMAIL PROTECTED]> wrote: > Hi, > > The following patch places the gjdoc source into the classpath tree, and > builds gjdoc into tools.zip. I tested this by first building and installing > classpath (make && sudo make install), then passing > --with-gjdoc=/usr/local/classpath/bin/gjdoc to ./configure, > as to generate javadoc on the second build. This works, but only if the > wrapper at /usr/local/classpath/bin/gjdoc has -Xmx512m -Xms512m as part of > the java flags, otherwise it will run out of memory while generating javadoc > for all of the classes. "-Xmx512m -Xms512m" could be default flags in > tools/gjdoc.in, but I don't know if this is an ideal solution. > > The patch is located at > http://icedtea.classpath.org/~jsumali/classpath-gjdoc.patch > (warning, 1.5MB), or > http://icedtea.classpath.org/~jsumali/classpath-gjdoc-patch.tar.gz > (233K). It should apply cleanly to what's in the classpath repo right now. > > Thanks, > Josh > >
Well this builds for me. A couple of minor changes: * The patch adds checks for antlr but only uses it as a parameter to JAVAC. The generated files should be removed from the patch and created using the detected antlr. Given we already indirectly depend on java for any appropriate javac, I'd see this as less of a problem than the recently added javah dependency. * Add an entry on this to NEWS. Please commit with the above changes. After this, I'd suggest we: * Make the building of tools optional so the antlr dependency can be dropped where new tools aren't required. * Provide an option to use in-tree tools for doc. and header generation. * Provide native builds of the tools. Thanks, -- Andrew :-) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: 94EFD9D8 (http://subkeys.pgp.net) Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
