On 23:02 Wed 16 Jun , Ivan Maidanski wrote:
> Hi!
>
> This patch contains:
> - a fix for Bidi constructor ("text" field wasn't initialized);
Good catch. I presume the constructor currently throws an NPE?
> - 2 code optimizations (for speed) in Bidi and CollationElementIterator).
>
Could you document how the optimization version works? It isn't immediately
clear to me.
I fail to see why work_text is being created at all and text not just used
for the charAt, substring and length operations. Any ideas?
> ChangeLog entries:
> * java/text/Bidi.java:
> (Bidi(AttributedCharacterIterator)): Fix uninitialized "text" field
> bug (initialize "text" instance field instead of creating "text" local
> variable).
> (requiresBidi(char[], int, int)): Optimize the expression (for speed).
> * java/text/CollationElementIterator.java:
> (setText(String)): Remove intern() call for work_text (since
> unnecessary).
>
> Regards.
Thanks,
--
Andrew :)
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
