Re: [cp-patches] Minor refactoring of PrintStre am - resubmission

[Ivan Maidanski]

I'm a bit sorry, I've forgot to document the NPE in PrintStream(out). So, here, 
the new (v3) version of the patch and changelog entries are presented.

Fri, 18 Jun 2010 14:20:21 +0400 Ivan Maidanski <iv...@mail.ru>:

> Hi!
> 
> This is the updated version of my patch for PrintStream 
> (http://comments.gmane.org/gmane.comp.java.classpath.patches/12964).
> 
> ChangeLog entries:
> ...

        * java/io/PrintStream.java:
        (line_separator): Convert static field to an instance one (to match
        the RI functionality).
        (PrintStream(String)): Use "new FileOutputStream(fileName)" instead of
        "new FileOutputStream(new File(fileName))".
        (PrintStream(String, String)): Likewise.
        (PrintStream(OutputStream, boolean)): Throw NPE if out is null;
        document NPE.
        (PrintStream(OutputStream, boolean, String)): Likewise.
        (print(char[], int, int, boolean)): Remove "pos" and "len" arguments.
        (writeChars(char[], int, int): Likewise.
        (print(String, boolean)): Don't pass "pos" and "len" parameters to
        writeChars() (as they are always set to 0 and buf.length,
        respectively).
        (print(char[], boolean)): Likewise.
        (print(char)): Likewise.
        (print(char[])): Likewise.
        (println()): Likewise.
        (println(char)): Likewise.
        (println(char[])): Likewise.
        (print(String, boolean)): Call flush() only if needed (to match the
        RI).
        (print(char[], boolean)): Likewise.
        (print(String, boolean)): Directly call out.flush() instead of flush()
        (the same as in the RI).
        (print(char[], boolean)): Likewise.
        (write(int)): Likewise.
        (write(byte[], int, int)): Likewise.
        (lastIndexOfNewLine(char[])): New private static method (called from
        print() only).
        (writeChars(char[])): Redirect to writeChars(String).
        (writeChars(String)): Don't call substring().
        (print(char)): Remove unnecessary synchronized.
        (println(char)): Likewise.
        (write(int)): Remove unnecessary "&" operation.
        (append(CharSequence, int, int)): Call subSequence() also for "null"
        string (the same as in the RI).


> 
> Regards.
> 
> 
> ATTACHMENT: application/octet-stream classpath-ivmai-12-v2.diff

classpath-ivmai-12-v3.diff
Description: Binary data