Hi Pekka, We already discussed it - as I recall Andrew said the first 2 are ok but he does not approve the last one (his opinion that ignore file should not include auto-generated files that could be wiped by "make clean").
To speak the truth, I'm personally more like Android's approach of placing all auto-generated files to "out" folder but it's hard to change it in Classpath, so I prefer that regardless of working tree project status (cleaned or built), "git status" shows no uncommitted files. PS. I also vote for ChangeLog file deprecation in favor of git commit log (Andrew rejected this idea half a year ago) but not a big deal to leave it as-is for now. Regards, Ivan Sat, 13 Oct 2012 10:02:48 +0300 (EEST) от Pekka Enberg <penb...@kernel.org>: > > > > >On Tue, 17 Jul 2012, Ivan Maidanski wrote: > > Just in case you missed the patches (it seems the letter still waits > moderator approval due > > to a 100KiB size): > > > > -------- Forwarded message -------- > > From: Ivan Maidanski <iv...@mail.ru> > > To: Andrew John Hughes <ahug...@redhat.com> > > CC: classpath-patches@gnu.org > > Date: Mon, 16 Jul 2012 13:59:38 +0400 > > Subject: Patch replacing all remaining .cvsignore with .gitignore > > > > Hi Andrew, > > > > On Apr 3, you committed a patch replacing root .cvsignore with .gitignore. > > > > I've prepared several patches to complete move to .gitignore (as well as to > excluded some > > more auto-generated files): > > 1. Replace all .cvsignore files with .gitignore - > > https://github.com/ivmai/classpath/commit/78f20cb718daad4164da4ceac9be54185d9c78ff > > 2. Remove duplicate entries in .gitignore; remove empty .gitignore files - > > https://github.com/ivmai/classpath/commit/6479ffea252e06fd2a6c4cac024cb2696091a850 > > 3. Add more auto-generated file to .gitignore - > > https://github.com/ivmai/classpath/commit/ae0451e67dc65a83b29aafa03887b432f81a6c07 > > Andrew, are you OK with me merging the above three commits to GNU > Classpath Git repository? > > Pekka >