Hi Pekka,
No problem. Thanks anyway.
The proposed test fails in Classpath but succeeds in OpenJDK. The original
Classpath StrictMath code has been ported from fdlibm and a dozen of bugs
emerged at that phase. The proposed code should fix discovered bugs. Of course,
the code contains math expressions and, thus, no easy to read and review.
Regards,
Ivan
Wed, 7 Nov 2012 15:04:48 +0200 Pekka Enberg <penb...@kernel.org>:
>
>
>
>
>Hi Ivan,
>
>
On Sat, Oct 27, 2012 at 6:10 PM, Ivan Maidanski <iv...@mail.ru> wrote:
>
> To continue pushing the patches, I've cherry-picked 2 patches (to
>
> https://github.com/ivmai/classpath/tree/ivmai4review-v3) containing
>
> StrictMath fixes and the corresponding tests:
>
> https://github.com/ivmai/classpath/commit/b0103d175bb012fcec411cc9e76257f3f257c39d
>
> (StrictMath changes)
>
> https://github.com/ivmai/classpath/commit/214c8bab72dc4689edf7ae1cd49e3a109c0746d7
>
> (StrictMath test)
>
>
>
> Some notes:
>
> - In the 1st patch I've removed several trailing spaces at EOLn in ChangeLog
>
> - I think it is ok not to post this as a separate patch
>
> - In the 2nd patch I've also fixed java.lang.reflect/ArrayTest (a one-line
>
> fix - I've commented out loadLibrary call but it might be better to remove
>
> this line at all)
>
>
I'm afraid I'll have to leave StrictMath reviewing for Andrew. I
>
really have no clue what that code is supposed to be doing. ;-)
>
>
Pekka
>
