> OK, I got around to testing the new patch and realized that the
> classpath.zip I put up on classpath.org wasn't quite right--some
> sort of version problem. I just put one up that *does* work--I
> tested it tonight with *gasp* Hello World!
:-)
I had a look at the patch today. I have some questions and some
change request before I add it to Japhar CVS.
Why was DLL loading order changed on arch/dynamic_loading.c?
I would like Classpath to change it's DLL names from javaio and
javalang, to classpath_io and classpath_lang. That way I can localize
the required Classpath change to DLL_findAlongPath().
Could Classpath change name on the following variables, to keep them
the same as JDK?
java.lang.Class declaringClass -> clazz
java.lang.String len -> count
str -> value
java.lang.Throwable message -> detailMessage
java.lang.Thread privateInfo -> PrivateInfo
java.lang.String.offset seem to be missing in Classpath. Why?
BTW: One checks for NULL pointers _before_, not after it is used.
Have a look at objects.c:cache_fields() and try again. :-)
Why do you do the caching in objects.c, and are you sure it is save to
cache this info?
That is it for today. Need some sleep. I've commited some of the
changes to configure.in and friends. I want to use FOR_CLASSPATH as
the define to be consistent with FOR_MOZILLA. I moved the define from
many Makefile.am's to config.h. Have a look in CVS.
More later. :-)
--
##> Petter Reinholdtsen <## | [EMAIL PROTECTED]
O- <SCRIPT Language="Javascript">window.close()</SCRIPT>
http://www.hungry.com/~pere/ | Go Mozilla, go! Go!