Hi,
On Sat, Jul 14, 2001 at 07:34:42PM -0400, John Keiser wrote:
>
> And yes, FYI, that means I'm volunteering to check this in, along with
> the doc changes, as soon as I figure out my CVS access again (new
> computer, no Kerberos). I'll test some of the doc changes to make sure
> we actually conform to the docs we want to put in :)
Oops. Should have reread the whole thread before enthousiastic hacking...
I already made the change locally. Should I commit the attached patch
or does that interfere with your work?
Note that for pserver cvs access to subversions.gnu.org you only need
a ssh key. See <https://savannah.gnu.org/integration.html>.
Cheers,
Mark
--
Stuff to read:
<http://www.toad.com/gnu/whatswrong.html>
What's Wrong with Copy Protection, by John Gilmore
Index: ChangeLog
===================================================================
RCS file: /cvs/classpath/ChangeLog,v
retrieving revision 1.142
diff -u -r1.142 ChangeLog
--- ChangeLog 2001/07/17 01:49:54 1.142
+++ ChangeLog 2001/07/17 22:10:01
@@ -1,3 +1,17 @@
+2001-07-17 Mark Wielaard <[EMAIL PROTECTED]>
+ Eric Blake <[EMAIL PROTECTED]>
+
+ * java/lang/Boolean.java (Boolean String): equalIgnoreCase() already
+ checks for null.
+ (value): Make field final
+ * java/lang/Byte.java (value): idem
+ * java/lang/Character.java (value): idem
+ * java/lang/Double.java (value): idem
+ * java/lang/Float.java (value): idem
+ * java/lang/Integer.java (value): idem
+ * java/lang/Long.java (value): idem
+ * java/lang/Short.java (value): idem
+
2001-07-17 Bryce McKinlay <[EMAIL PROTECTED]>
* java/util/LinkedList.java (clone): Clear the copy list with clear(),
Index: java/lang/Boolean.java
===================================================================
RCS file: /cvs/classpath/java/lang/Boolean.java,v
retrieving revision 1.15
diff -u -r1.15 Boolean.java
--- java/lang/Boolean.java 2001/07/09 23:24:12 1.15
+++ java/lang/Boolean.java 2001/07/17 22:10:01
@@ -62,7 +62,10 @@
*/
public static final Class TYPE = VMClassLoader.getPrimitiveClass("boolean");
- private boolean value;
+ /**
+ * The immutable value of this Boolean.
+ */
+ private final boolean value;
/**
* Create a <code>Boolean</code> object representing the value of the
@@ -88,7 +91,7 @@
* or false
*/
public Boolean(String s) {
- value = (s != null && s.equalsIgnoreCase("true"));
+ value = "true".equalsIgnoreCase(s);
}
/**
@@ -149,7 +152,7 @@
*/
public static boolean getBoolean(String name) {
String val = System.getProperty(name);
- return (val != null && val.equalsIgnoreCase("true"));
+ return ("true".equalsIgnoreCase(val));
}
/**
Index: java/lang/Byte.java
===================================================================
RCS file: /cvs/classpath/java/lang/Byte.java,v
retrieving revision 1.14
diff -u -r1.14 Byte.java
--- java/lang/Byte.java 2000/03/16 23:31:19 1.14
+++ java/lang/Byte.java 2001/07/17 22:10:02
@@ -58,7 +58,10 @@
*/
public static final Class TYPE = VMClassLoader.getPrimitiveClass("byte");
- private byte value;
+ /**
+ * The immutable value of this Byte.
+ */
+ private final byte value;
private static final char digits[] =
{ '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
Index: java/lang/Character.java
===================================================================
RCS file: /cvs/classpath/java/lang/Character.java,v
retrieving revision 1.14
diff -u -r1.14 Character.java
--- java/lang/Character.java 2001/03/23 11:09:58 1.14
+++ java/lang/Character.java 2001/07/17 22:10:02
@@ -1,5 +1,5 @@
/* java.lang.Character
- Copyright (C) 1998, 1999 Free Software Foundation, Inc.
+ Copyright (C) 1998, 1999, 2001 Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -426,7 +426,11 @@
public final static Subset HANJA = new Subset();
};
- private char value; // the character represented by this class
+ /**
+ * The immutable value of this Character.
+ */
+ private final char value;
+
static final long serialVersionUID = 3786198910865385080L;
/**
Index: java/lang/Double.java
===================================================================
RCS file: /cvs/classpath/java/lang/Double.java,v
retrieving revision 1.17
diff -u -r1.17 Double.java
--- java/lang/Double.java 2001/07/09 23:24:12 1.17
+++ java/lang/Double.java 2001/07/17 22:10:02
@@ -76,7 +76,10 @@
*/
public static final Class TYPE = VMClassLoader.getPrimitiveClass("double");
- private double value;
+ /**
+ * The immutable value of this Double.
+ */
+ private final double value;
/**
* Load native routines necessary for this class.
Index: java/lang/Float.java
===================================================================
RCS file: /cvs/classpath/java/lang/Float.java,v
retrieving revision 1.16
diff -u -r1.16 Float.java
--- java/lang/Float.java 2001/07/09 23:24:12 1.16
+++ java/lang/Float.java 2001/07/17 22:10:02
@@ -73,7 +73,10 @@
*/
public static final Class TYPE = VMClassLoader.getPrimitiveClass("float");
- private float value;
+ /**
+ * The immutable value of this Float.
+ */
+ private final float value;
static
{
Index: java/lang/Integer.java
===================================================================
RCS file: /cvs/classpath/java/lang/Integer.java,v
retrieving revision 1.16
diff -u -r1.16 Integer.java
--- java/lang/Integer.java 2001/01/07 23:00:31 1.16
+++ java/lang/Integer.java 2001/07/17 22:10:03
@@ -62,7 +62,10 @@
*/
public static final Class TYPE = VMClassLoader.getPrimitiveClass("int");
- private int value;
+ /**
+ * The immutable value of this Integer.
+ */
+ private final int value;
private static final char digits[] =
{ '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
Index: java/lang/Long.java
===================================================================
RCS file: /cvs/classpath/java/lang/Long.java,v
retrieving revision 1.9
diff -u -r1.9 Long.java
--- java/lang/Long.java 2001/01/07 23:00:31 1.9
+++ java/lang/Long.java 2001/07/17 22:10:03
@@ -61,7 +61,10 @@
*/
public static final Class TYPE = VMClassLoader.getPrimitiveClass("long");
- private long value;
+ /**
+ * The immutable value of this Long.
+ */
+ private final long value;
private static final char digits[] =
{ '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
Index: java/lang/Short.java
===================================================================
RCS file: /cvs/classpath/java/lang/Short.java,v
retrieving revision 1.8
diff -u -r1.8 Short.java
--- java/lang/Short.java 2001/01/07 23:00:31 1.8
+++ java/lang/Short.java 2001/07/17 22:10:03
@@ -59,7 +59,10 @@
*/
public static final Class TYPE = VMClassLoader.getPrimitiveClass("short");
- private short value;
+ /**
+ * The immutable value of this Short.
+ */
+ private final short value;
private static final char digits[] =
{ '0', '1', '2', '3', '4', '5', '6', '7', '8', '9',
