"Jeroen Frijters" <[EMAIL PROTECTED]> writes: > Hi, > > I really like this change and I have a few comments: > > - Please move forName(String) to VMClass, some VMs might be able to get > the caller's ClassLoader in a more efficient way. > - Same goes for isArray(), getting the class name can potentially be an > expensive operation.
For these I used the VMClass versions as simply ways a JVM could indicate they wanted to do something special but it neither is required to do much of anything. Check javadoc for specifics. > - getSigners() should return a clone of the signers array. Used signers.clone(). > - internalGetMethods() should not return overridden virtual methods > multiple times, see attached file for what I think is a correct > implementation Applied your patch, thanks. Brian -- Brian Jones <[EMAIL PROTECTED]> _______________________________________________ Classpath mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/classpath
