>>>>> "graydon" == graydon hoare <[EMAIL PROTECTED]> writes:

graydon> 2003-09-16  Graydon Hoare  <[EMAIL PROTECTED]>
graydon>        * java/awt/BufferedImage.java (setData): Support non-component
graydon>        sample models.
graydon>        (getData): Same.

This is ok.  There's a couple style nits though.

graydon> +        // slower path
graydon> +        int samples[] = null;
graydon> +        samples = src.getPixels (x, y, w, h, samples);

The `null' here is redundant; there are a couple of these.
I'd either do the assignment and declaration at once, or just not
initialize samples.  (In java this is always safe due to the definite
assignment rules.)

Tom


_______________________________________________
Classpath mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/classpath

Reply via email to