On Mon, 2004-04-05 at 10:59, Ingo PrÃtel wrote: > Note new attachment.
> Index: java/awt/image/SampleModel.java > =================================================================== > RCS file: /cvsroot/classpath/classpath/java/awt/image/SampleModel.java,v > retrieving revision 1.2 > diff -u -r1.2 SampleModel.java > --- java/awt/image/SampleModel.java 22 Jan 2002 22:26:59 -0000 1.2 > +++ java/awt/image/SampleModel.java 5 Apr 2004 14:57:53 -0000 > @@ -58,7 +58,9 @@ > > public SampleModel(int dataType, int w, int h, int numBands) > { > - if ((w<=0) || (h<=0)) throw new IllegalArgumentException(); > + if ((w<=0) || (h<=0)) > + throw new IllegalArgumentException( (w<=0?" width<=0":" width is ok") > + +(h<=0?" height<=0":" height is ok")); This patch is fine, except for the formatting. The GNU coding style that Classpath uses mandates that there should always be spaces between operators and their operands. (w<=0?" width<=0":" width is ok") should be: (w <= 0 ? " width<=0" : " width is ok") Thanks, Tom _______________________________________________ Classpath mailing list [EMAIL PROTECTED] http://mail.gnu.org/mailman/listinfo/classpath