Il giorno gio, 06/07/2006 alle 11.53 -0400, Thomas Fitzsimmons ha
scritto:

> > -static jclass get_jlist_reference (JNIEnv *env, jclass jlist_class);
> > +static jclass get_jlist_reference (JNIEnv * env, jclass jlist_class);
> 
> Why did you change the formatting here?  GNU style is JNIEnv *env.

Sorry, this was indent works... passed unnoticed...

The attached patch should be better (I hope! Sometimes eclipse keeps
changing my indentation!).

> Tom

Thanks,
Mario

2006-07-06  Mario Torre  <[EMAIL PROTECTED]>

    * native/jni/gconf-peer/GConfNativePeer.c:
    Fixed indentation to be more compliant to the GNU coding
    guidelines.

Java_gnu_java_util_prefs_gconf_GConfNativePeer_gconf_1client_1unset):
    Added explicit test for errors in the GConf backend.

(Java_gnu_java_util_prefs_gconf_GConfNativePeer_gconf_1client_1get_1string):
    Added explicit test for errors in the GConf backend.
    Fixed Segmentation Fault when non valid key names are
    given as input.

(Java_gnu_java_util_prefs_gconf_GConfNativePeer_gconf_1client_1set_1string):
    likewise.

(Java_gnu_java_util_prefs_gconf_GConfNativePeer_gconf_1client_1dir_1exists):
    Added explicit test for errors in the GConf backend.
    * gnu/java/util/prefs/gconf/GConfNativePeer.java:
    Added javadoc comments for all native methods.
    (nodeExist): removed test to check for valid absolute path name
    for nodes.
    (startWatchingNode): likewise.
    (stopWatchingNode): likewise.
    (setString): likewise, plus fixed javadoc comments.
    (unset): likekwise.
    (getKey): likewise.
    (getKeys): likewise, also fixed javadoc comments.
    (getChildrenNodes): likewise.
    * gnu/java/util/prefs/GConfBasedPreferences.java:
    changed DEFAULT_USER_ROOT to /apps/classpath.
    (constructor): Test to check for a valid absolute path for nodes
    is now in the contructor for that node, instead of being on
    each method of the backend.
    (getGConfKey): removed empty new line.

-- 
Lima Software, SO.PR.IND. s.r.l.
http://www.limasoftware.net/
pgp key: http://subkeys.pgp.net/

Please, support open standards:
http://opendocumentfellowship.org/petition/
http://www.nosoftwarepatents.com/

Attachment: gconf_preferences_backend_2006-07-06.patch.tar.gz
Description: application/compressed-tar

Reply via email to