> > http://zhadum.east/export/ws/clearview/clearview-ipmpdev/webrev/ > > > > (Only the ifconfig.c and ip_rcm.c changes are relevant.) Seb, could you > > please take a look? > > usr/src/cmd/cmd-inet/usr.sbin/ifconfig/ifconfig.c > > * General (and mumbling/ranting to myself): There are no less than 20 > calls to strchr(name, ':') in ifconfig.c. You'd figure that at some > point, someone would have added some code to parse the name once in some > common code-path.
This is ifconfig we're talking about here. Garbage is expected ;-) > * 3160: The v4compat check that was here before looks like a > pre-existing bug that wasn't explicitly stated in your description of > these changes. Is it the case that setting DEFAULT_IP=IP_VERSION4 > in /etc/default/inet_type would lead to mis-behavior of the configinfo > subcommand? It certainly looks that way. Correct. > * 3634: Why not also make this change at 3426 and 3538? Because it's unrelated to this bug fix, and I was trying to keep the changes targeted at this point. -- meem
