On Sat, 2008-11-29 at 14:47 -0500, Peter Memishian wrote: > > This includes the bugfix request from earlier today, along with a couple > > of other simple fixes: > > > > http://zhadum.east/export/ws/clearview/clearview-ipmpdev/webrev > > I've moved this webrev to: > > http://zhadum.east/export/ws/clearview/clearview-ipmpdev/misc-bugfixes
Overall, the changes look fine. For ip_rput_fragment() and ip_rput_frag_v6(), there are ASSERT() calls to make sure that recv_ill and inill are non-NULL, but it seems odd to check for that and not also ASSERT() that ill is non-NULL. Really, the system will fall over without either ASSERT() anyway, so it's not a big deal. Also, would it be useful to ASSERT() that they're equal (recv_ill or inill and ill) when ill is not an IPMP ill? -Seb
