On Tue, 2008-12-16 at 01:27 -0500, Peter Memishian wrote: > > > > http://zhadum.east/ws/clearview/clearview-ipmpdev/misc-bugfixes/ > > > > Just one comment: > > > > usr/src/uts/common/io/ib/clients/rds/rds_ioctl.c 141 > > and > > usr/src/uts/common/rpc/rpcib..c 4718 > > > > * If more than 4 interfaces are plumbed between the SIOCGLIFNUM and > > here, what are the implications? > > We'd ignore those IP interfaces beyond the fourth one. Although I've > written code to handle this before, I'm not convinced it matters, since > it'd mean the addition of new IP interfaces was racing with our > SIOCGLIFCONF and I don't think it'd be observable to know whether a given > IP interface was created before or after the SIOCGLIFCONF returned. > (In the old days when SIOCGLIFCONF returned EINVAL when the buffer was > too small, it was necessary.)
A bad outcome would have been to fail the entire operation and ignored all interfaces (instead of just the new ones), but if that isn't the case, then that's fine. -Seb
