> Because quite a bit of the mac and dls state is protected by the 
 > perimeter. If we need to access that state it would be an issue. 
 > Currently I have been able to get away with it, but I am not sure if 
 > that would hold in the long run. You can take a look at 
 > dls_devnet_stat_update(). The webrev is at
 > 
 > http://jurassic-x4600.sfbay/net/infotech/export/fix-ws/webrev/
 >
 > I have just started a gldv3 test suite run.
 > 
 > Cathy: Can you please take a look at the webrev, since most of the fix 
 > is in dls_mgmt.c

Not a code review, but why does dls_devnet_create() now need to get the
ddp from dls_devnet_set()?  Also, not sure why dls_devnet_unset() is now
done after the mac_perim_exit() -- assuming there's a reason, a comment
seems warranted.  Also `mph' in dls_devnet_stat_update() is no longer
needed.

--
meem

Reply via email to