On 07/06/07, Cathy Zhou <Cathy.Zhou at sun.com> wrote: > Honest, I feel architecturally speaking, we might need a third module to > keep this functions. > > I moved them from dls to mac, because I feel strange that mac modules to > call dls functions. For example, mac_open() calls > dls_linkmgmt_get_macname(), and softmac modules to call > dls_linkmgmt_create() and dls_linkmgmt_destroy(), or vsw functions call > dls_linkmgmt_get_linkid(). >
In the original code the mac module did not specify -N misc/dls in its options and therefore could not call into dls; there was no reason to. When the original vanity naming stuff was ripped out, and the minimal link management code that went with it, I believe mac was modified to 'automagically' create a default link for a mac interface upon registration. Hopefully this will now be handled differently and therefore mac should once again stand alone with no other module dependencies, restoring the nicely layered code structure. Paul -- Paul Durrant http://www.linkedin.com/in/pdurrant
