> On Thu, 2009-07-16 at 14:01 -0700, Peter Memishian wrote: > > > That's a fair request. I'll add details on what ip functions are used > > > and why. > > > > OK, great. Just let me know when the updated doc has this and I'll take > > one last pass. > > I've massaged section 7.2 to contain this information. There is an > annotated list of IP functions called at the end of this section. Let > me know what you think. > > http://www.opensolaris.org/os/project/clearview/iptun/iptun-design.pdf
Looks good. I presume there are a few other related routines used, such as ire_refrele(). Speaking of ire_refrele(), please don't make the same mistake e.g. sadb makes and use IRE_REFRELE(), as that leads to really nasty IRE refcounting bugs if you end up sticking a DEBUG ip module on a non-DEBUG system (or vice-versa). I looked over the other updates and those look fine as well. -- meem
