svn commit: r1399998 - in /incubator/clerezza/trunk/uima/uima.utils/src/main/java/org/apache/clerezza/uima/utils: ExternalServicesFacade.java UIMAExecutor.java UIMAUtils.java

[tommaso]

Author: tommaso
Date: Fri Oct 19 08:44:18 2012
New Revision: 1399998

URL: http://svn.apache.org/viewvc?rev=1399998&view=rev
Log:
[CLEREZZA-695] - uima-utils module: adding final modifiers, removing useless 
null initializations

Modified:
    
incubator/clerezza/trunk/uima/uima.utils/src/main/java/org/apache/clerezza/uima/utils/ExternalServicesFacade.java
    
incubator/clerezza/trunk/uima/uima.utils/src/main/java/org/apache/clerezza/uima/utils/UIMAExecutor.java
    
incubator/clerezza/trunk/uima/uima.utils/src/main/java/org/apache/clerezza/uima/utils/UIMAUtils.java

Modified: 
incubator/clerezza/trunk/uima/uima.utils/src/main/java/org/apache/clerezza/uima/utils/ExternalServicesFacade.java
URL: 
http://svn.apache.org/viewvc/incubator/clerezza/trunk/uima/uima.utils/src/main/java/org/apache/clerezza/uima/utils/ExternalServicesFacade.java?rev=1399998&r1=1399997&r2=1399998&view=diff
==============================================================================
--- 
incubator/clerezza/trunk/uima/uima.utils/src/main/java/org/apache/clerezza/uima/utils/ExternalServicesFacade.java
 (original)
+++ 
incubator/clerezza/trunk/uima/uima.utils/src/main/java/org/apache/clerezza/uima/utils/ExternalServicesFacade.java
 Fri Oct 19 08:44:18 2012
@@ -38,7 +38,7 @@ import java.util.Map;
  */
 public class ExternalServicesFacade implements UIMAServicesFacade {
 
-  private UIMAExecutor uimaExecutor;
+  private final UIMAExecutor uimaExecutor;
 
   private Map<String, Object> parameterSetting = new HashMap<String, Object>();
 
@@ -68,7 +68,7 @@ public class ExternalServicesFacade impl
 
   public FeatureStructure getLanguage(String document) throws UIMAException {
 
-    FeatureStructure languageFS = null;
+    FeatureStructure languageFS;
 
     try {
 
@@ -108,7 +108,7 @@ public class ExternalServicesFacade impl
   }
 
   public FeatureStructure getCategory(String document) throws UIMAException {
-    FeatureStructure categoryFS = null;
+    FeatureStructure categoryFS;
     try {
 
       // analyze the document

Modified: 
incubator/clerezza/trunk/uima/uima.utils/src/main/java/org/apache/clerezza/uima/utils/UIMAExecutor.java
URL: 
http://svn.apache.org/viewvc/incubator/clerezza/trunk/uima/uima.utils/src/main/java/org/apache/clerezza/uima/utils/UIMAExecutor.java?rev=1399998&r1=1399997&r2=1399998&view=diff
==============================================================================
--- 
incubator/clerezza/trunk/uima/uima.utils/src/main/java/org/apache/clerezza/uima/utils/UIMAExecutor.java
 (original)
+++ 
incubator/clerezza/trunk/uima/uima.utils/src/main/java/org/apache/clerezza/uima/utils/UIMAExecutor.java
 Fri Oct 19 08:44:18 2012
@@ -31,7 +31,7 @@ import java.util.Map;
  */
 public class UIMAExecutor {
 
-  private AEProvider aeProvider;
+  private final AEProvider aeProvider;
 
   public UIMAExecutor(AEProvider aeProvider) {
     this.aeProvider = aeProvider;

Modified: 
incubator/clerezza/trunk/uima/uima.utils/src/main/java/org/apache/clerezza/uima/utils/UIMAUtils.java
URL: 
http://svn.apache.org/viewvc/incubator/clerezza/trunk/uima/uima.utils/src/main/java/org/apache/clerezza/uima/utils/UIMAUtils.java?rev=1399998&r1=1399997&r2=1399998&view=diff
==============================================================================
--- 
incubator/clerezza/trunk/uima/uima.utils/src/main/java/org/apache/clerezza/uima/utils/UIMAUtils.java
 (original)
+++ 
incubator/clerezza/trunk/uima/uima.utils/src/main/java/org/apache/clerezza/uima/utils/UIMAUtils.java
 Fri Oct 19 08:44:18 2012
@@ -129,7 +129,7 @@ public class UIMAUtils {
           if (featureValue != null) {
             featureNode.addPropertyValue(ENTITY.featureValue, featureValue);
             log.info(new StringBuilder("Added feature 
").append(feature.getName()).append(" with value ")
-                    .append(featureValue.toString()).toString());
+                    .append(featureValue).toString());
           }
 
           // add feature to the annotation node