[
https://issues.apache.org/jira/browse/CLEREZZA-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797117#action_12797117
]
Manuel Innerhofer commented on CLEREZZA-60:
-------------------------------------------
in concept.rdf:
- improve descriptions of queryTemplate, searchResult and defaultGraph. How
are these properties related to their subjects?
- improve description of searchTerm
- Shouldn't the domain of sparqlEndPoint be RemoteConceptProvider?
in RemoteConceptProvider
- unused logger
in LocalConceptProvider
- Pass the ContentGraphProvider as argument to the contructor instead of
ConceptProviderManager.
- I think it would be better you also pass the TcManger as a contructor
argument instead of using TcManager.getInstance().
in ConceptProviderManager
- This component is exposed with the service interface
ConceptProviderManager.class, which has a public methods getStaticFile,
getProviderList(@Context UriInfo uriInfo) and updateConceptProviders, which I
think are not a very useful in the OSGi context.
- The only method you actually use of this service is getConceptProviders()
which has package visibility.
- I think you should define an interface that defines the method
getConceptProviders and let ConceptProviderManager implement it. You could
probably give the interface also package visibility if you don't want it to be
used by other bundles.
- You should implement the deactivate, where you call
conceptProviderList.clear().
> REST service to search for concepts managed by registered concept providers
> given a search term
> -----------------------------------------------------------------------------------------------
>
> Key: CLEREZZA-60
> URL: https://issues.apache.org/jira/browse/CLEREZZA-60
> Project: Clerezza
> Issue Type: Sub-task
> Reporter: Hasan
> Assignee: Hasan
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
