Hi all, I've updated CLEREZZA-616 with the NOTICE contents which I think should be reviewed. It'd be great if you could help me on fixing those NOTICE files. Thanks, Tommaso
2011/8/22 Reto Bachmann-Gmür <[email protected]> > On Mon, Aug 22, 2011 at 10:51 AM, Hasan Hasan <[email protected]> wrote: > > Thanks Tommaso, > > > > I took a look at the modified NOTICE files. I think they are ok now. > > @Reto, why do we need to re-bundle ops4j? is that due to the exclusion of > > slf4j? why? > You mean swissbox? the bug motivating the re-bundling has been fixed > by now, so we could also add the various jars individually > > Cheers > Reto > > > By the way, the project description in pom.xml > > of ext.org.ops4j.pax.swissbox.tinybundles is wrong. > > I would like to know first if we can just use the version available on > maven > > repo or whether we do need our version before fixing this. > > > > cheers > > hasan > > > > On Mon, Aug 22, 2011 at 10:25 AM, Tommaso Teofili < > [email protected] > >> wrote: > > > >> Thank you very much Hasan, I'll commit these changes. > >> Please take a moment to review if the fixed NOTICE files look good now. > >> Cheers, > >> Tommaso > >> > >> 2011/8/22 Hasan Hasan <[email protected]> > >> > >> > Hi Tommaso, > >> > > >> > The NOTICE.txt in ext.org.json.simple is from us, thus can be extended > >> with > >> > the standard NOTICE > >> > The NOTICE.txt in ext.org.ops4j.pax.swissbox.tinybundles is wrong > (copied > >> > from the json simple NOTICE.txt) and can be overwritten as well. > >> > The NOTICE.txt in bundledevtool can also be extended > >> > > >> > cheers > >> > hasan > >> > > >> > On Mon, Aug 22, 2011 at 9:17 AM, Tommaso Teofili > >> > <[email protected]>wrote: > >> > > >> > > Hello Reto, > >> > > > >> > > 2011/8/20 Reto Bachmann-Gmür <[email protected]> > >> > > > >> > > > Hi Tommaso > >> > > > > >> > > > Thanks for having taken care of this. > >> > > > > >> > > > Which google code references are you referring to? > >> > > > > >> > > > reto@reto-HPE-540ch:~/projects/apache/clerezza/trunk/parent$ grep > >> > > > google `find -name NOTICE.txt` > >> > > > ./ext.org.ops4j.pax.swissbox.tinybundles/NOTICE.txt: > >> > > > http://code.google.com/p/json-simple/ > >> > > > > >> > > > > >> > > > >> > > >> > ./ext.org.ops4j.pax.swissbox.tinybundles/target/classes/META-INF/NOTICE.txt: > >> > > > http://code.google.com/p/json-simple/ > >> > > > ./bundledevtool/NOTICE.txt:Uses code from: > >> > > > http://code.google.com/p/simple-build-tool/ > >> > > > ./bundledevtool/target/classes/META-INF/NOTICE.txt:Uses code from: > >> > > > http://code.google.com/p/simple-build-tool/ > >> > > > ./ext.org.json.simple/NOTICE.txt: > >> http://code.google.com/p/json-simple/ > >> > > > ./ext.org.json.simple/target/classes/META-INF/NOTICE.txt: > >> > > > http://code.google.com/p/json-simple/ > >> > > > > >> > > > > >> > > yes exactly the above ones; should we just add the standard Clerezza > >> > NOTICE > >> > > text to those contents? > >> > > Cheers, > >> > > Tommaso > >> > > > >> > > > >> > > > > >> > > > Cheers, > >> > > > Reto > >> > > > > >> > > > On Sat, Aug 20, 2011 at 10:35 AM, Tommaso Teofili > >> > > > <[email protected]> wrote: > >> > > > > I've added the Apache parent POM to Clerezza parent, this should > >> > allow > >> > > > > correct LICENSE/NOTICE generation and RAT report when launching > mvn > >> > > > > release:prepare; however some NOTICE files need to be checked by > >> > > someone > >> > > > > with "historical knowledge" (maybe Reto) as I am not aware of, > for > >> > > > example, > >> > > > > what the references to Google code projects mean. > >> > > > > Can anyone help me in reviewing the NOTICE files (see > >> CLEREZZA-616)? > >> > > > > Regards, > >> > > > > Tommaso > >> > > > > > >> > > > > 2011/8/6 Reto Bachmann-Gmür <[email protected]> > >> > > > > > >> > > > >> On Mon, Jul 25, 2011 at 2:51 PM, Tommaso Teofili > >> > > > >> <[email protected]> wrote: > >> > > > >> > 2011/7/25 Bertrand Delacretaz <[email protected]> > >> > > > >> > > >> > > > >> >> Hi, > >> > > > >> >> > >> > > > >> >> On Mon, Jul 25, 2011 at 9:10 AM, Tommaso Teofili > >> > > > >> >> <[email protected]> wrote: > >> > > > >> >> > ...The tarball and the signatures for this second RC made > by > >> > Reto > >> > > > are > >> > > > >> >> available > >> > > > >> >> > here: > >> > > > >> >> > > >> > > > >> >> > http://people.apache.org/~reto/clerezza-release-201107/ > >> > > > >> >> > >> > > > >> >> -1 for now. > >> > > > >> >> > >> > > > >> >> Sorry about that, it's based on items 1) and 2) below. > >> > > > >> >> > >> > > > >> >> 1) Let me know if I missed something but IMO many NOTICE.txt > >> > files > >> > > > are > >> > > > >> >> broken, see CLEREZZA-616 > >> > > > >> >> > >> > > > >> >> 2) Do we have a RAT report for this release somewhere? If > not, > >> > the > >> > > > >> >> best is IMO to use the Maven rat plugin, and add exclusions > in > >> > the > >> > > > >> >> poms as needed. > >> > > > >> >> This is what Stanbol is doing, see the rat profile in [1] > and > >> > > > >> >> exclusions example in [2]. > >> > > > >> >> > >> > > > >> > > >> > > > >> > I agree with you Bertrand, I didn't notice those broken > NOTICE > >> > > files, > >> > > > for > >> > > > >> > the Maven RAT plugin it should be easy to do. > >> > > > >> > If Reto could run a mvn:release rollback I can take care of > the > >> > > above > >> > > > >> tasks. > >> > > > >> > Regards, > >> > > > >> > Tommaso > >> > > > >> Saw this mail only now that I'm back from holidays. Now running > >> mvn > >> > > > >> release:rollback after doing an svn up. > >> > > > >> > >> > > > >> there is a rat-report attached to CLEREZZA-485 > >> > > > >> > >> > > > >> Cheers, > >> > > > >> Reto > >> > > > >> > >> > > > >> > >> > > > >> > > >> > > > >> > > >> > > > >> >> > >> > > > >> >> 3 ) The release archives are signed by the 57A262A0 key, is > >> that > >> > > > >> >> available somewhere? > >> > > > >> >> IMO that should be in a > >> > > > >> >> > >> > http://svn.apache.org/repos/asf/incubator/clerezza/trunk/KEYSfile. > >> > > > >> >> > >> > > > >> >> Apart from that, the build looks good! > >> > > > >> >> > >> > > > >> >> -Bertrand > >> > > > >> >> > >> > > > >> >> [1] > >> > > > >> > >> > > > http://svn.apache.org/repos/asf/incubator/stanbol/trunk/parent/pom.xml > >> > > > >> >> [2] search for "apache-rat-plugin" in > >> > > > >> >> > >> > > > >> >> > >> > > > >> > >> > > > > >> > > > >> > > >> > http://svn.apache.org/repos/asf/incubator/stanbol/trunk/enhancer/autotagging/pom.xml > >> > > > >> >> > >> > > > >> > > >> > > > >> > >> > > > > > >> > > > > >> > > > >> > > >> > > >
