Then it looks like removing it from the distro is totally painless.
On a side note, in Cayenne we tried to keep the distro user-buildable
at some point, but later switched to an approach that if a user wants
to build Cayenne, (s)he is better off checking out a tag from SVN, and
following the dev guide instructions. On the long run this not only
saved developers time, as we only need to maintain a single build
system, but also saved lots of user frustration, as the two build
systems would often get out of sync.
Andrus
On Dec 20, 2008, at 1:43 PM, Bob Schellink wrote:
Actually its only used at build time. I think the reason it was
included was to be able to build a Click distro without having to
download extra dependencies.
kind regards
bob
Andrus Adamchik wrote:
Didn't realize that Click actually includes checkstyle in the
distro. I am curious what runtime function it performs?
Andrus
On Dec 20, 2008, at 1:25 PM, Bob Schellink wrote:
Couple of issues have come up with the jars we ship in our lib
folder.
Checkstyle-all.jar is LGPL based, so will have to be removed from
the distribution.
Even though a taskdef in our build.xml is dependent on checkstyle,
the build still works without the jar. Ant simply prints a warning.
Was thinking of adding the jar to the get-deps target, however
only checkstyle.jar (the one without dependencies) is available
from maven repo's. Checkstyle itself depends on a further 5
dependencies, so I'm not sure we should add that to the get-deps
task.
We can enhance the checkstyle task to notify Click developers
about manually downloading and adding the checkstyle-all.jar to
their classpath when building Click.
Alternatively another ant target could be added get-checkstyle.
The other issue is with dev.jar which doesn't have a license but I
recall it was authored by Malcolm? Guess we can decompile the code
and release it under Apache2.0?
kind regards
bob
