Just did a quick evaluation. Haven't looked at the technical aspects,
but rather the compliance issues.
I noticed one minor thing that we'd rather fix before posting the
release for the Incubator PMC vote: while click-2.0.1-incubating.zip
correctly uses "incubating" label, inside the archive, folder name is
just "click-2.0.1", so when a user unpacks the archive, "incubating"
label disappears:
~/opt: unzip -l click-2.0.1-incubating.zip |head
Archive: click-2.0.1-incubating.zip
Length Date Time Name
-------- ---- ---- ----
0 01-25-09 00:54 click-2.0.1/
0 01-25-09 00:54 click-2.0.1/build/
0 01-25-09 00:54 click-2.0.1/dist/
0 01-25-09 00:54 click-2.0.1/documentation/
0 01-25-09 00:54 click-2.0.1/documentation/docs/
I'd say this needs to be fixed as it unintentionally circumvents the
intent of the "incubating" label. Don't think there's a hard rule
regarding this, but I suggest we stay on the safe side.
Another small thing, that would not affect my vote, still I figured
I'd mention. NOTICE.txt file has this note for a number of JS
libraries: "Please note this library is NOT included in the Click
runtime library." IMO what's important here is which library is
included in the *distribution zip* (not the runtime). In this case, at
least Rico and YUI are a part of the examples:
./examples/webapp/assets/js/rico.js
./examples/webapp/control/populate-on-select.js
./examples/webapp/yui/container/container_core-min.js
./examples/webapp/yui/editor/simpleeditor-min.js
The license of these libs is compatible with Apache, so there's no
problem including them. But the corresponding notes in the NOTICE.txt
should probably be taken out.
Andrus
On Jan 25, 2009, at 1:43 AM, Bob Schellink wrote:
Hi all,
I've prepared the Click 2.0.1 distribution which is available here:
http://people.apache.org/~sabob/click/click/2.0.1/
Please cast your vote for publishing this release.
The voting period is 72 hours and closes at 12am GMT on Wed, 28th.
Here is my +1.
kind regards
bob
