[
https://issues.apache.org/jira/browse/CLK-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694582#action_12694582
]
Bob Schellink commented on CLK-421:
-----------------------------------
-1 for including this in Click. It adds no value to the target audience, the
corporate developer.
Btw ClickClick uses Prettify for syntax highlighting, SourceViewer is only used
for Velocity.
> Move SourceViewer from examples to utils
> ----------------------------------------
>
> Key: CLK-421
> URL: https://issues.apache.org/jira/browse/CLK-421
> Project: Click
> Issue Type: Improvement
> Reporter: Demetrios Kyriakis
> Priority: Minor
> Attachments: SourceViewerPanel.diff
>
>
> Please move the SourceViewer utility class from click-examples to some util
> package inside click because:
> - it is usable in more places than just click-examples, and users duplicate
> it all the time, by copy and paste.
> - it could be used even in error reporting to display nice source code where
> errors appear.
> - even ClickClick has a duplicated class for SourceViewer
> - it would be much simpler to make other example webapplications
> moredeveloper friendly if this
> class would be present in utils.
> - other concurrent frameworks don't have such an utility and display pure
> text :).
> Thank you,
> Demetrios.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
