[ 
https://issues.apache.org/jira/browse/CLK-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699178#action_12699178
 ] 

Joseph Schmidt commented on CLK-407:
------------------------------------

> Have committed implementation of this to SF project. Would appreciate a 
> review or comments before committing to Apache. 
If I see right, it is for 406, not for this issue (being 407).
Adrian's solution was working for me pretty well.

Since you made a general interface however, I think it would be better to 
combine it with the "onSecurityCheck" too (I like it much more than the 
container solution since it's portable).


> Menu improvements - more properties: enable/disable, show/hide 
> ---------------------------------------------------------------
>
>                 Key: CLK-407
>                 URL: https://issues.apache.org/jira/browse/CLK-407
>             Project: Click
>          Issue Type: Improvement
>          Components: extras
>            Reporter: Demetrios Kyriakis
>
> Please improve the Menu Control, by allowing the user to show/hide menu 
> items, and also to enable/disable them.
> Right now, this is not possible at all with the Menu Control :(.
> This is very limiting, making the existing Menu Control useless for most user 
> applications, thus forcing the users
> to make their own menu controls (or the hack the original one). 
> There's no need for these properties to be present in menu.xml, since their 
> role is mostly at runtime:
> - enable/disable would allow to enable or disable a menu item (so to show it 
> but make it unclickable).
> - show/hide would allow to to show and hide menu items (of course if the user 
> doesn't have a specific role, the menu will be hidden).
> Regarding the API, it would be important to have practical methods for hiding 
> and disabling menu items:
> something like Menu#hide(Menu item) would not be very practical since in most 
> cases the "item" reference is not present
> so it should be Menu#hide(String path), and when applied, to seach this in 
> the children items too.
> Another improvement would be if the Menu Click control would use Link 
> Controls for the items (since that's what they are).
> Thank you,
> Demetrios.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to