Hi Eddie, I guess my comment was not enough. It appeared to me the autoconf.h is not required for configure so I thought it's good to be removed. Do we actually need to include autoconf.h?
Thanks, Joonwoo On Wed, Sep 29, 2010 at 3:46 PM, Eddie Kohler <[email protected]> wrote: > Hi Joonwoo, > > I believe the right answer is to include either <generated/autoconf.h> or > <linux/autoconf.h>, whichever works. It's there for a reason. > > Perhaps we should have a symbol like CLICK_LINUX_AUTOCONF_H which is defined > to the correct spelling, and then #include that. > > Or we could/should use AC_CHECK_HEADERS to check for generated/autoconf.h, > and include that if it's available, otherwise linux/autoconf.h. That's > probably better. > > Thoughts? > E > > > On 09/25/2010 10:28 PM, Joonwoo Park wrote: >> >> include/linux/autoconf.h has been moved to include/generated >> >> Signed-off-by: Joonwoo Park<[email protected]> >> --- >> configure.in | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) >> >> diff --git a/configure.in b/configure.in >> index ab998cd..2f3152e 100644 >> --- a/configure.in >> +++ b/configure.in >> @@ -1148,7 +1148,6 @@ fixincludes.pl execution failed. >> #define namespace linux_namespace >> #define false linux_false >> #define true linux_true >> -#include<linux/autoconf.h> >> #include<asm/types.h>]]) >> >> > _______________________________________________ click mailing list [email protected] https://amsterdam.lcs.mit.edu/mailman/listinfo/click
