On Wed, 15 Jun 2022 18:04:59 GMT, Alexey Ivanov <[email protected]> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Moved doc change. > > src/java.desktop/share/classes/javax/swing/text/html/HTMLEditorKit.java line > 28: > >> 26: package javax.swing.text.html; >> 27: >> 28: import sun.awt.AppContext; > > In JDK code, internal classes are listed below public `java.*` and `javax.*` > packages. The order was correct. Thanks, I fixed this in my IntelliJ auto import settings. > src/java.desktop/share/classes/javax/swing/text/html/HTMLEditorKit.java line > 1184: > >> 1182: * table describes what this factory will build by >> 1183: * default. >> 1184: * <p> > > I'd rather move this block below the table. The sentence above introduces the > table, then it lists how the common HTML tags are handled. This added > paragraph describes how unsupported and unknown tags are handled. > > Does it make sense to use lists? > > * When the container is editable, … > * When the container is not editable, > * If tag is recognized but not supported, … > * If tag is unknown or not supported, … > > Or simply split the two cases in different paragraphs for better readability? I added the list formatting for better readability. ------------- PR: https://git.openjdk.org/jdk/pull/7446
