On Fri, 13 May 2022 16:53:00 GMT, Magnus Ihse Bursie <[email protected]> wrote:

>> I ran `codespell` on the `src/java.desktop` directory, and accepted those 
>> changes where it indeed discovered real typos.
>> 
>> I ignored typos in public methods and variables. Maybe they can be fixed 
>> later on without much fanfare, if they are in internal classes. Typos in 
>> exposed APIs are likely here to stay.
>> 
>> I will update copyright years using a script before pushing (otherwise like 
>> every second change would be a copyright update, making reviewing much 
>> harder).
>> 
>> The long term goal here is to make tooling support for running `codespell`. 
>> The trouble with automating this is of course all false positives. But 
>> before even trying to solve that issue, all true positives must be fixed. 
>> Hence this PR.
>
> Magnus Ihse Bursie has updated the pull request incrementally with 17 
> additional commits since the last revision:
> 
>  - Update src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java
>    
>    Co-authored-by: Alexey Ivanov 
> <[email protected]>
>  - Update src/java.desktop/unix/classes/sun/awt/X11/XBaseMenuWindow.java
>    
>    Co-authored-by: Alexey Ivanov 
> <[email protected]>
>  - Update src/java.desktop/unix/classes/sun/awt/X11/XBaseMenuWindow.java
>    
>    Co-authored-by: Alexey Ivanov 
> <[email protected]>
>  - Update src/java.desktop/share/classes/sun/swing/SwingUtilities2.java
>    
>    Co-authored-by: Alexey Ivanov 
> <[email protected]>
>  - Update src/java.desktop/share/classes/sun/swing/SwingUtilities2.java
>    
>    Co-authored-by: Alexey Ivanov 
> <[email protected]>
>  - Update src/java.desktop/share/classes/sun/awt/image/ImagingLib.java
>    
>    Co-authored-by: Alexey Ivanov 
> <[email protected]>
>  - Update src/java.desktop/share/classes/sun/awt/image/ImagingLib.java
>    
>    Co-authored-by: Alexey Ivanov 
> <[email protected]>
>  - Update 
> src/java.desktop/share/classes/javax/swing/tree/FixedHeightLayoutCache.java
>    
>    Co-authored-by: Alexey Ivanov 
> <[email protected]>
>  - Update 
> src/java.desktop/share/classes/javax/swing/text/html/parser/TagStack.java
>    
>    Co-authored-by: Alexey Ivanov 
> <[email protected]>
>  - Update src/java.desktop/share/classes/javax/swing/text/html/CSS.java
>    
>    Co-authored-by: Alexey Ivanov 
> <[email protected]>
>  - ... and 7 more: https://git.openjdk.org/jdk/compare/40c585cd...98e635a5

Marked as reviewed by aturbanov (Committer).

-------------

PR: https://git.openjdk.org/jdk/pull/8328

Reply via email to