On Fri, 24 Jun 2022 17:52:18 GMT, Phil Race <[email protected]> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix Right Option Key handling > > src/java.desktop/macosx/classes/com/apple/laf/AquaKeyBindings.java line 95: > >> 93: "alt altgraph LEFT", DefaultEditorKit.previousWordAction, >> 94: "alt altgraph RIGHT", DefaultEditorKit.nextWordAction, >> 95: "alt UP", DefaultEditorKit.beginLineUpAction, > > I find it utterly bizarre to say we need "altgraph" when macOS doesn't have > altgraph - certainly not on the k/bs on current mac books or imacs. > > My take is that the previous fix JDK-8151136 was a mistake and we should have > just excluded the test there on macOS. As per offline discussion with @prrace ALT_GRAPH support done via JDK-8151136 is reverted and tests testing ALT_GRAPH in macos is excluded.. @prrace can you please review? ------------- PR: https://git.openjdk.org/jdk/pull/9230
