On Fri, 8 Jul 2022 22:42:20 GMT, Alisen Chung <ach...@openjdk.org> wrote:
>> Removed darkening of icons on button press in Aqua to match other L&Fs. The >> icon darkening was causing this test to fail on MacOS. >> >> The test is passing on all platforms after this change. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > updated copyright dates, removed debug print statements src/java.desktop/macosx/classes/com/apple/laf/AquaButtonUI.java line 413: > 411: if (tmpIcon == null) { > 412: if (icon instanceof ImageIcon) { > 413: tmpIcon = new > ImageIcon(AquaUtils.generateSelectedDarkImage(((ImageIcon)icon).getImage())); Any other reason to remove the usage of grayimage as the pressedIcon other than this failed test? Probably it is better to set the pressedIcon in the test? ------------- PR: https://git.openjdk.org/jdk/pull/9436